X-Git-Url: http://www.dolda2000.com/gitweb/?a=blobdiff_plain;f=src%2Fuserplex.c;h=c50a15c84586b86ac4aef34a6626bd2041dcf110;hb=615f3ba3b9ced7a23e5c7c48ad1ff446ff733358;hp=3a2da874512f4760bcfbdc69bcc3f0291955ced9;hpb=f2df7a1b1aeeb0cec2309aeb62fae051fd3c687c;p=ashd.git

diff --git a/src/userplex.c b/src/userplex.c
index 3a2da87..c50a15c 100644
--- a/src/userplex.c
+++ b/src/userplex.c
@@ -53,6 +53,7 @@ static void login(struct passwd *pwd)
 {
     int fd;
     
+    setsid();
     if(getuid() == 0) {
 	if(initgroups(pwd->pw_name, pwd->pw_gid)) {
 	    flog(LOG_ERR, "could not init group list for %s: %s", pwd->pw_name, strerror(errno));
@@ -86,33 +87,50 @@ static void login(struct passwd *pwd)
      * getting Kerberos credentials, running PAM session modules, and
      * who knows what. I'll add them along as I find them useful. */
     if(((fd = open(".ashd/output", O_WRONLY | O_APPEND)) >= 0) ||
-       ((fd = open("/dev/null", 0)) >= 0)) {
+       ((fd = open("/dev/null", O_WRONLY)) >= 0)) {
 	dup2(fd, 1);
 	close(fd);
     }
     if(((fd = open(".ashd/error", O_WRONLY | O_APPEND)) >= 0) ||
-       ((fd = open("/dev/null", 0)) >= 0)) {
+       ((fd = open("/dev/null", O_WRONLY)) >= 0)) {
 	dup2(fd, 2);
 	close(fd);
     }
 }
 
-static void execchild(struct passwd *pwd)
+static void discardreq(int fromfd)
+{
+    struct hthead *req;
+    int fd;
+    
+    if((fd = recvreq(fromfd, &req)) >= 0) {
+	freehthead(req);
+	close(fd);
+    }
+}
+
+static void execchild(struct passwd *pwd, struct hthead *forreq, int reqfd)
 {
     if(!ignore)
 	execl(".ashd/handler", ".ashd/handler", NULL);
     if(dirname != NULL) {
-	if(access(dirname, X_OK | R_OK))
+	if(access(dirname, X_OK | R_OK)) {
+	    discardreq(0);
+	    simpleerror(reqfd, 404, "Not Found", "No such resource could be found.");
 	    return;
+	}
     }
     execvp(childspec[0], childspec);
+    discardreq(0);
+    flog(LOG_ERR, "could not start request handler for user `%s': %s", pwd->pw_name, strerror(errno));
+    simpleerror(reqfd, 500, "User Error", "Could not start any request handler for that user.");
 }
 
-static int forkchild(char *usrnm)
+static int forkchild(char *usrnm, struct hthead *forreq, int reqfd)
 {
     struct passwd *pwd;
     pid_t pid;
-    int i, fd[2];
+    int fd[2];
     
     /* XXX: There should be a way for the child to report errors (like
      * 404 when htpub doesn't exist), but for now I don't bother with
@@ -126,36 +144,33 @@ static int forkchild(char *usrnm)
     if((pid = fork()) < 0)
 	return(-1);
     if(pid == 0) {
-	for(i = 3; i < FD_SETSIZE; i++) {
-	    if(i != fd[0])
-		close(i);
-	}
 	dup2(fd[0], 0);
 	close(fd[0]);
+	close(fd[1]);
 	login(pwd);
-	execchild(pwd);
+	execchild(pwd, forreq, reqfd);
 	exit(127);
     }
     close(fd[0]);
+    fcntl(fd[1], F_SETFD, FD_CLOEXEC);
     return(fd[1]);
 }
 
 static void serve2(struct user *usr, struct hthead *req, int fd)
 {
     if(usr->fd < 0)
-	usr->fd = forkchild(usr->name);
+	usr->fd = forkchild(usr->name, req, fd);
     if(sendreq(usr->fd, req, fd)) {
 	if((errno == EPIPE) || (errno == ECONNRESET)) {
 	    /* Assume that the child has crashed and restart it. */
 	    close(usr->fd);
-	    usr->fd = forkchild(usr->name);
+	    usr->fd = forkchild(usr->name, req, fd);
 	    if(!sendreq(usr->fd, req, fd))
 		return;
 	}
 	flog(LOG_ERR, "could not pass on request to user `%s': %s", usr->name, strerror(errno));
 	close(usr->fd);
 	usr->fd = -1;
-	simpleerror(fd, 500, "User Error", "The request handler for that user keeps crashing.");
     }
 }